Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[list] sort list reply alphabetically (Fixes #836) #994

Merged
merged 12 commits into from Sep 4, 2019
Merged

[list] sort list reply alphabetically (Fixes #836) #994

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f6b6981
[list] sort list reply alphabetically (Fixes #836)
Saviq Aug 26, 2019
50b5f0e
[tests] parameterize TableFormatter list tests
Saviq Sep 2, 2019
297a443
[tests] make ListFormatterSuite formatter-generic
Saviq Sep 2, 2019
dabb279
[tests] make FormatterSuite reply-generic
Saviq Sep 2, 2019
287ca9c
[tests] move table info tests to the FormatterSuite
Saviq Sep 2, 2019
2775f64
[tests] move FindReply table formatting tests to FormatterSuite
Saviq Sep 2, 2019
976a079
[tests] move JsonFormatter tests to FormatterSuite
Saviq Sep 2, 2019
13a3861
[tests] move CSVFormatter tests to FormatterSuite
Saviq Sep 2, 2019
3c910fd
[tests] move YamlFormatter tests to FormatterSuite
Saviq Sep 2, 2019
5770b11
[tests] add prepend case in FormatterSuite
Saviq Sep 2, 2019
42c329b
[tests] add comments explaining FormatterSuite parameters
Saviq Sep 4, 2019
b53a330
[tests] use structured bindings in FormatterSuite
Saviq Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions include/multipass/cli/format_utils.h
View file
Open in desktop
Expand Up @@ -52,8 +52,14 @@ Instances multipass::format::sorted(const Instances& instances)

auto ret = instances;
const auto petenv_name = Settings::instance().get(petenv_key).toStdString();
std::partial_sort(std::begin(ret), std::next(std::begin(ret)), std::end(ret),
[&petenv_name](const auto& a, const auto& /*unused*/) { return a.name() == petenv_name; });
std::sort(std::begin(ret), std::end(ret), [&petenv_name](const auto& a, const auto& b) {
if (a.name() == petenv_name)
return true;
else if (b.name() == petenv_name)
return false;
else
return a.name() < b.name();
});

return ret;
}
Expand Down