[bugfix] defer reconciling pebble layer for exporter #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
requested review from
shayancanonical,
taurus-forever,
carlcsaposs-canonical and
phvalguima
phvalguima
approved these changes
Sep 5, 2023
carlcsaposs-canonical
approved these changes
Sep 5, 2023
| logger.debug("Defer reconcile mysqld exporter") | ||
| event.defer() | ||
| return | ||
|
|
||
| self.current_event = event |
There was a problem hiding this comment.
I would be careful with current_event and deferring a relation broken event
In this situation, I don't think it will break anything unless there's a deferred event that runs in the same charm execution as the relation broken event. However, something that uses has_cos_relation or current_event in the future that is not aware that relation broken can be deferred could introduce issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
COS relation creation/departure is reconciling the pebble layer, which will hinder the charm initialization in case it happens before other initial events (leader-election, pebble-ready).
This scenario will happens on relating with COS right from the deployment, e.g. in a bundle.
Solution
Defer handler to run after initialization.