Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for s3 tls-ca-chain #396

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add support for s3 tls-ca-chain #396

merged 3 commits into from
Feb 20, 2024

Conversation

sabaini
Copy link
Contributor

@sabaini sabaini commented Feb 2, 2024

Fixes #395

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (18da4a3) 65.52% compared to head (a7d7585) 65.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/charms/mysql/v0/s3_helpers.py 16.66% 10 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   65.52%   65.37%   -0.15%     
==========================================
  Files          17       17              
  Lines        3089     3099      +10     
  Branches      406      409       +3     
==========================================
+ Hits         2024     2026       +2     
- Misses        936      945       +9     
+ Partials      129      128       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sabaini
Add support for s3 tls-ca-chain
e306b19 
Fixes canonical#395

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
paulomach
paulomach requested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabaini thank you for your contribution. Left couple comments to address

lib/charms/mysql/v0/s3_helpers.py Show resolved Hide resolved
lib/charms/mysql/v0/s3_helpers.py Show resolved Hide resolved
@sabaini
Bump libpatch as base64 is added
effaa59 
Per review feedback

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
@sabaini
Ensure ca_file is closed
a7d7585 
Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
paulomach
paulomach approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

taurus-forever
taurus-forever approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@paulomach paulomach merged commit 528121c into canonical:main Feb 20, 2024
36 of 39 checks passed
@paulomach paulomach mentioned this pull request Feb 20, 2024
Merged
@taurus-forever taurus-forever mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomach paulomach paulomach approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@carlcsaposs-canonical carlcsaposs-canonical Awaiting requested review from carlcsaposs-canonical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No CA chain support
4 participants
@sabaini @paulomach @taurus-forever @carlcsaposs-canonical