Set httpx and httpcore logger level to WARNING
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightkube has noisy INFO & DEBUG level logs
carlcsaposs-canonical
changed the title
httpx and httpcore logger level to WARNING
paulomach
approved these changes
Dec 11, 2023
taurus-forever
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpxandhttpcore(used bylightkube) have noisy INFO & DEBUG level logsSupersedes #145. It still seems a bit backwards to me to enable DEBUG level logs for all python dependencies and then manually disable logging for dependencies of our dependencies. Personally, I only think DEBUG level logs are useful for charm ecosystem code (e.g. ops, the charm, charm libs)—but it seems like the consensus from this discussion is different