Bootstrap with force #187
Merged
Bootstrap with force #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the existence of old router user to cleanup router from cluster metadata, force bootstrap so that the metadata does not need to be cleaned up. Fixes canonical/mysql-k8s-operator#345. The issue was that the router charm would delete the user & router metadata, but that only the user deletion would go through. Then, on the router charm's next hook, the bootstrap failed because the metadata was not cleaned up.
paulomach
approved these changes
Jan 10, 2024
yes but I decided not to implement it so that we wouldn't need an upgrade migration I think since the only benefit is supporting the corner case where a non-charmed router is deployed on the same host, it's not worth implementing—but happy to implement if others see it differently |
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Jan 10, 2024
Instead of relying on the existence of old router user to cleanup router from cluster metadata, force bootstrap so that the metadata does not need to be cleaned up. Fixes canonical/mysql-k8s-operator#345. The issue was that the router charm would delete the user & router metadata, but that only the user deletion would go through. Then, on the router charm's next hook, the bootstrap failed because the metadata was not cleaned up. Ported from canonical/mysql-router-k8s-operator#187
This was referenced Jan 10, 2024
|
Hi experts, I am stuck on this issue, any manual workaround I can do to resolve this for now? |
@sunpengRvi Which revision of the charm are you using? Is it deployed in production? |
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Mar 5, 2024
Instead of relying on the existence of old router user to cleanup router from cluster metadata, force bootstrap so that the metadata does not need to be cleaned up. Fixes canonical/mysql-k8s-operator#345. The issue was that the router charm would delete the user & router metadata, but that only the user deletion would go through. Then, on the router charm's next hook, the bootstrap failed because the metadata was not cleaned up. Ported from canonical/mysql-router-k8s-operator#187
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Mar 5, 2024
Instead of relying on the existence of old router user to cleanup router from cluster metadata, force bootstrap so that the metadata does not need to be cleaned up. Fixes canonical/mysql-k8s-operator#345. The issue was that the router charm would delete the user & router metadata, but that only the user deletion would go through. Then, on the router charm's next hook, the bootstrap failed because the metadata was not cleaned up. Ported from canonical/mysql-router-k8s-operator#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the existence of old router user to cleanup router from cluster metadata, force bootstrap so that the metadata does not need to be cleaned up.
Fixes canonical/mysql-k8s-operator#345. The issue was that the router charm would delete the user & router metadata, but that only the user deletion would go through. Then, on the router charm's next hook, the bootstrap failed because the metadata was not cleaned up.
Additional context: https://chat.canonical.com/canonical/pl/temrphcp3in5xqftkaxgowqtkr