Implement netplan get/set CLI and DBus API #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 88.16% 88.19% +0.02%
==========================================
Files 9 9
Lines 2771 2778 +7
==========================================
+ Hits 2443 2450 +7
Misses 328 328
Continue to review full report at Codecov.
|
slyon
force-pushed
the
slyon/uc20-set
branch
2 times, most recently
from
fc9522f
to
a9e694a
Compare
slyon
changed the title
slyon
force-pushed
the
slyon/uc20-set
branch
from
cb0c5be
to
ff0b104
Compare
sil2100
approved these changes
Sep 29, 2020
|
Thanks again for your very constructive review! I cleaned & fixed up according to your comments. Ready for merge \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
netplan get [nested.key] / set nested.key=valueCLI andio.netplan.Netplan.Get() / Set(String configDelta, String originHint)DBus API.It allows to get/set values from/to the merged netplan configuration as scalar, sequence or mappings.
Validation of settings, added via
netplan set ..., is done by calling into thelibnetplanparser using Pythonctypes. Whereas thenetplan get [...]command makes use of netplan's Python parser (config_manager). This is to keep it simple for now, unifying the parsers will be for another time...Examples
netplan getnetplan get ethernets.eth0.dhcp4netplan set ethernets.eth0.dhcp4=true --origin-hint=99_snapd --root-dir=/tmpnetplan set "network.ethernets.eth0={addresses: [1.2.3.4/24], dhcp4: true}"busctl call io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan Getbusctl call io.netplan.Netplan /io/netplan/Netplan io.netplan.Netplan Set ss "network.ethernets.eth3={addresses: [5.6.7.8/24], dhcp4: no}" ""Checklist
make checksuccessfully.make check-coverage).