Fix NM unmanaged-devices (changes behavior) #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyon
force-pushed
the
slyon/fix-integration-tests
branch
from
0b3d5fa
to
d4e4f39
Compare
slyon
changed the title
slyon
force-pushed
the
slyon/fix-integration-tests
branch
from
fd1bf66
to
bc188b0
Compare
Some interfaces, matched by MAC, could change their MAC address after assignment (e.g. a bond member), thus NM would not ignore this interface anymore, even if it is also matched by interface-name.
slyon
force-pushed
the
slyon/fix-integration-tests
branch
from
bc188b0
to
9e76e80
Compare
slyon
changed the title
sil2100
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
Ok, this looks sane. I suppose it could potentially change behavior for some people, right? I mean, I think it was a 'bug' that on NM one could only match on one or the other, not both at once, but I guess it would be good to document that in the changelog at least.
slyon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
interface-name:ANDmac:, instead of defaulting to MAC if available)test_bond_mac/NetworkdChecklist
make checksuccessfully.make check-coverage).