Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix dch after adding the new 0.106.1 tag #364

Merged
merged 1 commit into from May 26, 2023

Conversation

daniloegea
Copy link
Collaborator

After adding the new tag from the stable/0.106 branch, dch is failing with:

New version specified (0.106-78-g3074070) is less than
the current version number (0.106.1-0ubuntu1)! Use -b to force.

Basically, git describe is still describing the tag 0.106 and not 0.106.1.
With this change, we'll first find the lastest tag before calling describe.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

After adding the new tag from the stable/0.106 branch, dch is failing
with:

  New version specified (0.106-78-g3074070) is less than
  the current version number (0.106.1-0ubuntu1)!  Use -b to force.

Basically, git describe is still describing the tag 0.106 and not
0.106.1.
With this change, we'll first find the lastest tag before calling
describe.
@schopin-pro
Copy link
Contributor

ACK. I haven't gone through all the scenarios in which this could fail down the line, and in the case of our CI config I figure a quickfix now is better than an hypothetical "correct" fix that doesn't yet exist.

@schopin-pro schopin-pro merged commit 24ab13c into canonical:main May 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants