Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netplan.c: Don't drop files with just global values on 'set' (LP: #2027584) #382

Merged
merged 1 commit into from Jul 24, 2023

Commits on Jul 24, 2023

  1. netplan.c: Don't drop files with just global values on 'set' (LP: #20…

    …27584)
    
    The "unlink" part at the bottom of netplan.c:netplan_state_update_yaml_hierarchy
    seems to ignore any global values (such as "renderer") and operates on files
    containing netdefs only.
    
    The issue is happens due to a combination of the following PRs:
    canonical#254
    canonical#299
    
    Which got SRUed into Jammy via 0.105-0ubuntu2~22.04.2
    
    Here's a minimal reproducer:
    ```
    netplan set network.renderer=NetworkManager --origin-hint=00-no-netdefs-just-globals
    netplan set network.ethernets.eth99.dhcp4=true --origin-hint=90-some-netdefs
    ls -l /etc/netplan/
    netplan set network.ethernets.eth99=NULL
    cat /etc/netplan/00-no-netdefs-just-globals.yaml
    ```
    
    FR-4793
    slyon committed Jul 24, 2023
    Copy the full SHA
    f2c8f64 View commit details
    Browse the repository at this point in the history