Skip to content

parse: Downgrade NM passthrough warning to debug#384

Merged
daniloegea merged 1 commit into
canonical:mainfrom
slyon:nm-passthrough-warning
Jul 20, 2023
Merged

parse: Downgrade NM passthrough warning to debug#384
daniloegea merged 1 commit into
canonical:mainfrom
slyon:nm-passthrough-warning

Conversation

@slyon

@slyon slyon commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

Description

With the NetworkManager integration in place there will be many more cases where "nm-devices" are used, and we don't want to spam system logs with our warnings.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

With the NetworkManager integration in place there will be many more
cases where "nm-devices" are used, and we don't want to spam system
logs with our warnings.
@slyon
slyon requested a review from daniloegea July 20, 2023 12:16
@slyon

slyon commented Jul 20, 2023

Copy link
Copy Markdown
Contributor Author

@daniloegea WDYT?

@daniloegea daniloegea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it :D lgtm

@daniloegea
daniloegea merged commit 22b8bfb into canonical:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants