Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli:status: Make rich pretty printing optional #388

Merged
merged 2 commits into from Aug 15, 2023

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Aug 1, 2023

Description

cli:status: Make rich pretty printing optional

To avoid a hard dependency on python3-rich

E.g. needed for stable series SRUs (like Jammy), which don't support python3-rich in main

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

To avoid a hard dependency on python3-rich
@slyon slyon marked this pull request as ready for review August 14, 2023 15:49
@slyon slyon requested a review from daniloegea August 14, 2023 15:49
Copy link
Collaborator

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about interface names, but lgtm.

netplan_cli/cli/commands/status.py Outdated Show resolved Hide resolved
@slyon slyon merged commit 2a3f12a into canonical:main Aug 15, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants