Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: only run the coverity workflow on our repository #392

Merged
merged 1 commit into from Aug 14, 2023

Conversation

daniloegea
Copy link
Collaborator

Also, get the project version dynamically using meson introspect.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One little inline thought for consideration.

.github/workflows/coverity.yml Outdated Show resolved Hide resolved
Also, build a version ID based on the latest tag + commit so we can
easily identify what revision was scanned.
@daniloegea
Copy link
Collaborator Author

E: Package 'linux-modules-extra-5.15.0-1042-azure' has no installation candidate

Apparently some old kernel versions were purged again...

@slyon
Copy link
Collaborator

slyon commented Aug 14, 2023

E: Package 'linux-modules-extra-5.15.0-1042-azure' has no installation candidate

Apparently some old kernel versions were purged again...

Yeah.. I think the CI failures are related to https://ubuntu-archive-team.ubuntu.com/nbs.html cleaning. Should resolve itself eventually, once the CI runners are upgraded to a newer kernel. We shouldn't block on this.

@daniloegea daniloegea merged commit 397288f into canonical:main Aug 14, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants