Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse-nm: add support for VRF devices #398

Merged
merged 1 commit into from Aug 17, 2023
Merged

parse-nm: add support for VRF devices #398

merged 1 commit into from Aug 17, 2023

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Aug 16, 2023 •
edited by slyon

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@daniloegea daniloegea requested a review from slyon August 16, 2023 18:24
slyon
slyon approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one inline TODO, which I'd like to see addressed. Other than that, lgtm.

src/parse-nm.c Outdated Show resolved Hide resolved
src/parse-nm.c Outdated Show resolved Hide resolved
@daniloegea daniloegea merged commit 7e90ce5 into canonical:main Aug 17, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyon slyon slyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@daniloegea @slyon