Netplan state refactoring #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define default values to fields - Add a str() method that will return the route as a string in a format similar to the one returned from "ip route" - Defined to_dict() method that will be used by the JSON encoder when dumping the NetplanRoute class. - Refactor the _NetplanRouteIterator class to use **kwargs. It makes it clearer what fields we are assigning.
slyon
approved these changes
Aug 17, 2023
Make it a global object and add new types found in the Netplan state.
daniloegea
force-pushed
the
netplan_state_refactoring
branch
from
9207421
to
bfcd5c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's basically #386 without the diff part.
Checklist
make checksuccessfully.make check-coverage).