Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: support WPA2 and WPA3 Personal simultaneously #404

Merged
merged 1 commit into from Aug 28, 2023

Conversation

daniloegea
Copy link
Collaborator

@daniloegea daniloegea commented Aug 25, 2023

When using WPA-PSK and defining the password without the "auth" section, enable support for both WPA2 and 3 Personal. This will set the support for Protected Management Frames to optional implicitly.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

When using WPA-PSK and defining the password without the "auth" section,
enable support for both WPA2 and 3 Personal. This will set the support
for Protected Management Frames to optional implicitly.
@daniloegea daniloegea marked this pull request as ready for review August 28, 2023 15:04
@daniloegea daniloegea requested a review from slyon August 28, 2023 15:04
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

This should keep simple things simple. Allowing the casual user to "just connect" to any WPA2/3 personal network, providing only their password, as discussed in #402

@daniloegea daniloegea merged commit 5f1192c into canonical:main Aug 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants