Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix howto docs #430

Merged
merged 1 commit into from Jan 10, 2024
Merged

Fix howto docs #430

merged 1 commit into from Jan 10, 2024

Conversation

rkratky
Copy link
Contributor

@rkratky rkratky commented Dec 15, 2023

Description

This is a follow up to #429 -- don't merge before it.

Improve how-to docs:

  • Move intro to how-to landing page
  • Make headings consistently use "How to"
  • Remove (post-build) "How to" from TOC

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • N/A: New/changed keys in YAML format are documented.
  • N/A: (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad. Fix FR-6139

@rkratky rkratky added enhancement New feature or request documentation Documentation improvements. labels Dec 15, 2023
@rkratky rkratky force-pushed the FR-6139_fix-howtos branch 5 times, most recently from 2d51a1d to b717269 Compare December 15, 2023 18:34
Copy link
Collaborator

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me (only check the last commit).

doc/Makefile Outdated Show resolved Hide resolved
@rkratky rkratky force-pushed the FR-6139_fix-howtos branch 2 times, most recently from 8442fc0 to d3288ec Compare January 3, 2024 15:26
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes are looking mostly good to me. But we hit some build failures. Locally, make run hits an endless loop and I see a failure on the readthedocs CI, which might be related to doc/howtos.sh being incomplete. (Some of which might already be fixed in #429)

I also left some inline comments.

doc/howtos.sh Outdated Show resolved Hide resolved
doc/howto.md Outdated Show resolved Hide resolved
@rkratky rkratky force-pushed the FR-6139_fix-howtos branch 4 times, most recently from ea19a30 to d1e859a Compare January 5, 2024 16:06
@rkratky
Copy link
Contributor Author

rkratky commented Jan 5, 2024

@slyon This is finally building successfully on RTD, so I believe it's good to merge (after #429).

@rkratky
Copy link
Contributor Author

rkratky commented Jan 8, 2024

@slyon This is finally building successfully on RTD, so I believe it's good to merge (after #429).

Thanks, the changes are looking mostly good to me. But we hit some build failures. Locally, make run hits an endless loop and I see a failure on the readthedocs CI, which might be related to doc/howtos.sh being incomplete. (Some of which might already be fixed in #429)

I also left some inline comments.

Thanks. I was aware of those problems. Should be fixed now.

@slyon
Copy link
Collaborator

slyon commented Jan 9, 2024

@rkratky Could you please rebase this branch on top of main, in order to resolve the merge conflicts?

@rkratky
Copy link
Contributor Author

rkratky commented Jan 9, 2024

@rkratky Could you please rebase this branch on top of main, in order to resolve the merge conflicts?

Done. Sorry for the mess :)

Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could squash both commits into "Improve how-to docs" (or I can do a squash merge). The first commit seems to be a left-over from the rebase.

Also see my inline comments for a few final nitpicks before we can merge this.

doc/howto.md Outdated Show resolved Hide resolved
doc/Makefile Outdated Show resolved Hide resolved
- Move intro to how-to landing page
- Make headings consistently use "How to"
- Remove (post-build) "How to" from TOC
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning it all up! ❤️
LGTM.

@slyon slyon merged commit b44de52 into canonical:main Jan 10, 2024
5 checks passed
@rkratky rkratky deleted the FR-6139_fix-howtos branch January 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements. enhancement New feature or request
Projects
None yet
3 participants