New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix howto docs #430
Fix howto docs #430
Conversation
2d51a1d
to
b717269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me (only check the last commit).
8442fc0
to
d3288ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the changes are looking mostly good to me. But we hit some build failures. Locally, make run
hits an endless loop and I see a failure on the readthedocs CI, which might be related to doc/howtos.sh
being incomplete. (Some of which might already be fixed in #429)
I also left some inline comments.
ea19a30
to
d1e859a
Compare
d1e859a
to
6b14164
Compare
@slyon This is finally building successfully on RTD, so I believe it's good to merge (after #429).
Thanks. I was aware of those problems. Should be fixed now. |
@rkratky Could you please rebase this branch on top of |
6b14164
to
4a1d1de
Compare
Done. Sorry for the mess :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could squash both commits into "Improve how-to docs" (or I can do a squash merge). The first commit seems to be a left-over from the rebase.
Also see my inline comments for a few final nitpicks before we can merge this.
4a1d1de
to
c595d47
Compare
- Move intro to how-to landing page - Make headings consistently use "How to" - Remove (post-build) "How to" from TOC
c595d47
to
8c89668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for cleaning it all up! ❤️
LGTM.
Description
This is a follow up to #429 -- don't merge before it.
Improve how-to docs:
Checklist
make check
successfully.make check-coverage
).