Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples.md #442

Merged
merged 1 commit into from Feb 12, 2024

Conversation

sahil-sagwekar2652
Copy link
Contributor

@sahil-sagwekar2652 sahil-sagwekar2652 commented Feb 10, 2024

Description

In the how-to-create-a-bridge-with-a-vlan-for-libvirtd section, the correct path to where libvirtd creates the config file is /etc/libvirt/qemu/networks/

Apologies if this is not the correct process to report this. I found there was no tag to report documentation errors on Launchpad.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels Feb 12, 2024
@slyon slyon self-requested a review February 12, 2024 15:24
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to Netplan @sahil-sagwekar2652 !

This is exactly the right process you follows. There's also the documentation tag on Launchpad for Netplan, but a PR is much better.

LGTM.

@slyon slyon merged commit 1117556 into canonical:main Feb 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
2 participants