feat: expose client properties (#12)

To be able to identify the server and the user's own reviews.
canonical · Jun 2, 2023 · c05ede5 · c05ede5
1 parent 4da820b
commit c05ede5
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 16 deletions.
diff --git a/lib/src/client.dart b/lib/src/client.dart
@@ -7,19 +7,17 @@ import 'review.dart';
 
 class OdrsClient {
   OdrsClient({
-    required Uri url,
-    required String userHash,
-    required String distro,
+    required this.url,
+    required this.userHash,
+    required this.distro,
     HttpClient? client,
-  })  : _client = client ?? _createClient(url),
-        _url = url,
-        _userHash = userHash,
-        _distro = distro;
+  }) : _client = client ?? _createClient(url);
 
   final HttpClient _client;
-  final Uri _url;
-  final String _userHash;
-  final String _distro;
+
+  final Uri url;
+  final String userHash;
+  final String distro;
 
   static HttpClient _createClient(Uri url) {
     final client = HttpClient();
@@ -56,11 +54,11 @@ class OdrsClient {
     String? version,
   }) {
     final json = {
-      'user_hash': _userHash,
+      'user_hash': userHash,
       'app_id': appId,
       if (compatIds != null) 'compat_ids': compatIds,
       'locale': locale ?? Platform.localeName,
-      'distro': _distro,
+      'distro': distro,
       'limit': limit,
       'start': start,
       'version': version ?? 0,
@@ -95,7 +93,7 @@ class OdrsClient {
     final json = {
       'app_id': review.appId,
       'review_id': review.reviewId,
-      'user_hash': _userHash,
+      'user_hash': userHash,
       'user_skey': review.userSkey,
     };
     return _request('POST', '1.0/reviews/api/$vote', body: json);
@@ -112,10 +110,10 @@ class OdrsClient {
     required String description,
   }) {
     final json = {
-      'user_hash': _userHash,
+      'user_hash': userHash,
       'app_id': appId,
       'locale': locale ?? Platform.localeName,
-      'distro': _distro,
+      'distro': distro,
       'version': version,
       'user_display': userDisplay,
       'summary': summary,
@@ -134,7 +132,7 @@ class OdrsClient {
   }) async {
     final request = await _client.openUrl(
       method,
-      _url.resolve(path).replace(queryParameters: queryParameters),
+      url.resolve(path).replace(queryParameters: queryParameters),
     );
     request.headers.contentType = ContentType.json;
     for (final header in headers.entries) {

diff --git a/test/odrs_client_test.dart b/test/odrs_client_test.dart
@@ -12,6 +12,13 @@ import 'odrs_client_test.mocks.dart';
 void main() {
   final localhost = Uri.https('localhost:8080');
 
+  test('client properties', () async {
+    final client = OdrsClient(url: localhost, userHash: 'foo', distro: 'bar');
+    expect(client.url, equals(localhost));
+    expect(client.userHash, equals('foo'));
+    expect(client.distro, equals('bar'));
+  });
+
   test('get ratings', () async {
     final http = MockHttpClient();
     final url = localhost.resolve('/1.0/reviews/api/ratings');