fix: restore try-catch for HTML responses

[jpnurmi]

Partially reverts commit 2a4797a.

[jpnurmi]

Reopened:

• Unstable #1

[Feichtmeier]

is null also a correct value?

[jpnurmi]

for json['msg']? i don't know but we can probably find the source code somewhere. :) did you receive such a response that had "success": false but no message since you're asking?

[Feichtmeier]

I just thought if json['success'] == null then the exception would not be thrown but if null is a correct value then this is np I guess :) ?
I didn't test the code yet, just looked over the commit

[jpnurmi]

i'm not sure if i'm looking at the correct code but technically, the error reporting helper function in odrs-web does seem to allow omitting the message.

def json_error(msg=None, errcode=400):
    """Error handler: JSON output"""
    item = {}
    item["success"] = False
    if msg:
        item["msg"] = msg
    dat = json.dumps(item, sort_keys=True, indent=4, separators=(",", ": "))
    return Response(response=dat, status=errcode, mimetype="application/json")

however, the helper method is not called without a message anywhere in the codebase... 🤔

odrs/util.py:def json_error(msg=None, errcode=400):
odrs/views_api.py:    json_error,
odrs/views_api.py:        return json_error(str(e))
odrs/views_api.py:            return json_error("invalid data, expected %s" % key)
odrs/views_api.py:            return json_error("missing data, expected %s" % key)
odrs/views_api.py:        return json_error("the user_hash is invalid")
odrs/views_api.py:        return json_error("summary is too long")
odrs/views_api.py:        return json_error("description is too long")
odrs/views_api.py:            return json_error("%s is not a valid string" % key)
odrs/views_api.py:            return json_error("account has been disabled due to abuse")
odrs/views_api.py:        return json_error("already reviewed this app")
odrs/views_api.py:        return json_error("summary is too short")
odrs/views_api.py:        return json_error("description is too short")
odrs/views_api.py:        return json_error("review contains taboo word")
odrs/views_api.py:        return json_error(str(e))
odrs/views_api.py:            return json_error("invalid data, expected %s" % key)
odrs/views_api.py:            return json_error("missing data, expected %s" % key)
odrs/views_api.py:        return json_error("the user_hash is invalid")
odrs/views_api.py:        return json_error("no user for {}".format(user_hash))
odrs/views_api.py:        return json_error(str(e))
odrs/views_api.py:            return json_error("invalid data, required %s" % key)
odrs/views_api.py:            return json_error("missing data, expected %s" % key)
odrs/views_api.py:        return json_error("the user_hash is invalid")
odrs/views_api.py:        return json_error("the user_skey is invalid")
odrs/views_api.py:            return json_error("account has been disabled due to abuse")
odrs/views_api.py:            return json_error("all negative karma used up")
odrs/views_api.py:        return json_error("invalid user_skey")
odrs/views_api.py:        return json_error("already voted on this app")
odrs/views_api.py:        return json_error("invalid review ID")
odrs/views_api.py:        return json_error(str(e))
odrs/views_api.py:            return json_error("invalid data, required %s" % key)
odrs/views_api.py:            return json_error("missing data, expected %s" % key)
odrs/views_api.py:        return json_error("the user_hash is invalid")
odrs/views_api.py:        return json_error("the user_skey is invalid")
odrs/views_api.py:        return json_error("no review")
odrs/views_api.py:        return json_error("no review")
odrs/views_api.py:        return json_error("the app_id is invalid")
odrs/views_api.py:        return json_error("invalid user_skey")

[Feichtmeier]

If you're not sure you could eventually also check the http response code to be 200.
Sorry if this is not helpful