Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2929] snap for opensearch dashboard #1

Merged
merged 5 commits into from Feb 13, 2024
Merged

[DPE-2929] snap for opensearch dashboard #1

merged 5 commits into from Feb 13, 2024

Conversation

juditnovak
Copy link
Contributor

@juditnovak juditnovak commented Feb 5, 2024 •
edited

Snap package for Opensearch Dashboards.

See the README rendered here.

@juditnovak juditnovak changed the title Dpe 2929 snap for opensearch dashboard [DPE-2929] snap for opensearch dashboard Feb 5, 2024
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch 13 times, most recently from 0d1387f to 234fa51 Compare February 9, 2024 08:51
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch 3 times, most recently from 9143e1e to 25ba2b4 Compare February 9, 2024 12:20
@juditnovak juditnovak marked this pull request as ready for review February 9, 2024 12:20
taurus-forever
taurus-forever approved these changes Feb 9, 2024
View reviewed changes
Copy link

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I do not have blocking comments here, so LGTM.

I have some nice-to-have improvements which I reported here as an evil reviewer (as I am reviewing your code the first time). :-D

README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
helpers/io.sh Show resolved Hide resolved
scripts/wrappers/start.sh Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch 3 times, most recently from 02b1a93 to 3e919ee Compare February 12, 2024 11:52
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch 3 times, most recently from 60b2788 to ab1c842 Compare February 12, 2024 14:00
@juditnovak juditnovak requested review from Mehdi-Bendriss and delgod and removed request for delgod February 12, 2024 15:18
taurus-forever
taurus-forever approved these changes Feb 12, 2024
View reviewed changes
Copy link

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tnx!

Mehdi-Bendriss
Mehdi-Bendriss reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you. I left a few small comments.

We should add in a next PR:

  • CONTRIBUTOR.md
  • licenses/LICENSE-snap
  • licenses/LICENSE-opensearch-dashboards

scripts/wrappers/start.sh Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch 6 times, most recently from 312a7b9 to 2b9da6b Compare February 12, 2024 22:46
@juditnovak juditnovak force-pushed the DPE-2929_snap_for_opensearch_dashboard branch from 2b9da6b to f526697 Compare February 12, 2024 23:01
@juditnovak juditnovak merged commit 559f4a2 into main Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delgod delgod delgod left review comments

@taurus-forever taurus-forever taurus-forever approved these changes

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juditnovak @delgod @taurus-forever @Mehdi-Bendriss