Harness should always provide the remote app name in relation-broken #1128
Assignees
Labels
Comments
tonyandrewmeyer
added
bug
|
It could easily be that it reproduces with something like Juju 2.8, but I
don't think we need to keep compatibility with 2.8 anymore.
…On Thu, Feb 8, 2024 at 11:07 PM Tony Meyer ***@***.***> wrote:
Although it seems like sometimes JUJU_REMOTE_APP is not set in
relation-broken, the conclusion in the Juju investigation
<https://bugs.launchpad.net/juju/+bug/1960934> was that this should not
happen, and it couldn't be reproduced.
We should remove the special-casing in Harness that acts as if this *is*
the case
<https://github.com/search?q=repo%3Acanonical%2Foperator%20https%3A%2F%2Fbugs.launchpad.net%2Fjuju%2F%2Bbug%2F1960934&type=code>
.
—
Reply to this email directly, view it on GitHub
<#1128>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRQ7OXHCS2JVKUA6KX6K3YSWOIFAVCNFSM6AAAAABDA23K72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDMNBTGI2DANY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
benhoyt
pushed a commit
that referenced
this issue
Feb 27, 2024
… relation-broken (#1130) As far as the Juju team and I have been able to tell (see [comments in the Juju issue](https://bugs.launchpad.net/juju/+bug/1960934)) `JUJU_REMOTE_APP` is always set in relation-broken events. This PR removes the `Harness` behaviour that simulates `JUJU_REMOTE_APP` *not* being available (which was never consistently the case anyway) and the model code that blocks getting remote data during relation-broken (which is discouraged in the case where the entire integration is going away, but is permitted). Fixes #1128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Although it seems like sometimes JUJU_REMOTE_APP is not set in relation-broken, the conclusion in the Juju investigation was that this should not happen, and it couldn't be reproduced.
We should remove the special-casing in Harness that acts as if this is the case.
The text was updated successfully, but these errors were encountered: