leader-settings-changed firing before unit departure

[MiaAltieri]

Hi team. I had some weird behavior for this set up / situation

For Example. If you have these units:

A *
B
C

and A departs then you get these events hooks for each unit:
A: leader-settings-changed , mongodb-storage-detaching, mongodb-relation-departed(for A-B), mongodb-relation-departed(for A-C), stop, remove
B: mongodb-relation-departed (for A-B)
C: mongodb-relation-departed (for A-C),

According to @wallyworld and @rwcarlsen this is unexpected behaviour and should be looked into. As requested, this is my repo/branch where I observed this behaviour. It can be observed by first creating the necessary environment according to CONTRIBUTING.md. Once the environment has been created you can reproduce this with:

# pack and deploy
charmcraft pack
juju deploy -n3 ./*charm

# in a separate session
juju debug-hooks <leader_unit>

# remove unit 
juju remove-unit <leader_unit

[rwcarlsen]

If @wallyworld could clarify exactly what juju should be doing here that would help inform the best approach for dealing with things in the ops framework.

[jameinel]

This doesn't feel like an operator framework issue, but a juju issue https://bugs.launchpad.net/juju/+filebug

…

On Tue, Mar 1, 2022, 17:06 Robert Carlsen ***@***.***> wrote: If @wallyworld <https://github.com/wallyworld> could clarify exactly what juju *should* be doing here that would help inform the best approach for dealing with things in the ops framework here. — Reply to this email directly, view it on GitHub <#708 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABRQ7LJCMY6NXLJDPRRCELU5Y6BRANCNFSM5PUM4PHA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[rwcarlsen]

FWIW these docs suggest that the leader-settings changed event should be firing like this.

[rwcarlsen]

I hunted in the juju code for a bit and couldn't find anywhere that triggered a leader-settings-changed hook for unit departure. But my eyes and brain aren't very trained on reading the juju codebase yet. So maybe that doc page is just wrong (or out of date)...

[MiaAltieri]

@jameinel bug filed

[jnsgruk]

Nice, thanks all. Will close this for now and we can track this issue in the bug that Mia filed :)