Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Unit.reboot for machine charms #1041

Merged
merged 31 commits into from Oct 20, 2023
Merged

feat: add Unit.reboot for machine charms #1041

merged 31 commits into from Oct 20, 2023

Commits on Oct 10, 2023

  1. Expose juju-reboot [--now].

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8aec383 View commit details
    Browse the repository at this point in the history

  2. Fix name.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9aa26d8 View commit details
    Browse the repository at this point in the history

  3. Improve exception docs.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a8576c3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into juju-reboot-929

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    74b2e1f View commit details
    Browse the repository at this point in the history

  5. Remove whitespace.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3516f37 View commit details
    Browse the repository at this point in the history

  6. Update ops/model.py 

    Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
    @tonyandrewmeyer @benhoyt
    tonyandrewmeyer and benhoyt committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4607904 View commit details
    Browse the repository at this point in the history

  7. Update ops/testing.py 

    Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
    @tonyandrewmeyer @benhoyt
    tonyandrewmeyer and benhoyt committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    300fd84 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Rename exception & fix doc link.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cbd71d2 View commit details
    Browse the repository at this point in the history

  2. Fix type confusion.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9253398 View commit details
    Browse the repository at this point in the history

  3. Allow RebootNow as an exception class name.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    28063d5 View commit details
    Browse the repository at this point in the history

  4. Update test/test_testing.py 

    Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
    @tonyandrewmeyer @benhoyt
    tonyandrewmeyer and benhoyt committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d21dc3c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into juju-reboot-929

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    41ca79f View commit details
    Browse the repository at this point in the history

  6. Fix accidental change.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7fba4f1 View commit details
    Browse the repository at this point in the history

  7. Adjust docs as per code review.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5799f9e View commit details
    Browse the repository at this point in the history

  8. Note Unit.reboot addition.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    43acb42 View commit details
    Browse the repository at this point in the history

  9. Simplify documentation as per review comment.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f46c128 View commit details
    Browse the repository at this point in the history

  10. Add a property that tells you when reboot() was last called.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    09b6033 View commit details
    Browse the repository at this point in the history

  11. Also note the new harness property.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8f95030 View commit details
    Browse the repository at this point in the history

  12. Style fix.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0aaee0f View commit details
    Browse the repository at this point in the history

  13. Typo

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    42232d9 View commit details
    Browse the repository at this point in the history

  14. Typo

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f341653 View commit details
    Browse the repository at this point in the history

  15. Drive-by: update with other changes.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    20a391c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Add 'new in' version specifiers.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    50eec52 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge branch 'main' into juju-reboot-929

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2e56068 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into juju-reboot-929

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    15c7517 View commit details
    Browse the repository at this point in the history

  3. Provide a counter of the number of reboots, rather than a datetime, t… 

    …o ensure that it will change every time, even if the reboots are right next to each other.
    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7cc5bdc View commit details
    Browse the repository at this point in the history

  4. Have ops guarantee that nothing after reboot(now=True) will run, rath… 

    …er than relying on Juju.
    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    fdddc08 View commit details
    Browse the repository at this point in the history

  5. Use the same exception as the non-testing code.

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    cbfe4f8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into juju-reboot-929

    @tonyandrewmeyer
    tonyandrewmeyer committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    17e8be0 View commit details
    Browse the repository at this point in the history

  7. Update ops/testing.py 

    Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
    @tonyandrewmeyer @benhoyt
    tonyandrewmeyer and benhoyt committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2cdb33f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge branch 'main' into juju-reboot-929

    @benhoyt
    benhoyt committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9b544d0 View commit details
    Browse the repository at this point in the history