Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reinstate postgresql-operator tests now that issue is fixed #1116

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

benhoyt
Copy link
Collaborator

@benhoyt benhoyt commented Jan 30, 2024

Also update links to mysql issues.

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been a large refactor of secrets in the mysql charms over the few days (since I opened these PRs). The mysql-operator tests now pass and it seems like the problem no longer exists (deleting revisions has moved into data-platform-libs and is handled in a way that means that the cached secret shouldn't be accessed after deletion, I think).

The data-platform-libs issue (setting a secret twice can wipe the first value) still seems to exist but with the refactoring that code path isn't hit any more so the tests pass with current ops, even though that should still be fixed as far as I can tell.

There's also a further issue that only applies to mysql-k8s-operator, which is just that there is one specific test that relies on the "owner always peeks" behaviour. So that still fails, and I've opened a new PR for that.

.github/workflows/db-charm-tests.yaml Outdated Show resolved Hide resolved
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@benhoyt benhoyt merged commit 94263b0 into canonical:main Jan 30, 2024
28 checks passed
@benhoyt benhoyt deleted the reinstate-postgresql-charm-tests branch January 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants