feat: add the action's ID to the ActionEvent object #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UID environment variable.
Also add a basic test. Also dump the ability to specify the ID in Harness, that doesn't seem useful.
tonyandrewmeyer
commented
Feb 7, 2024
| @@ -1057,10 +1057,10 @@ class BoundStoredState: | |||
| if TYPE_CHECKING: | |||
| # to help the type checker and IDEs: | |||
| @property | |||
| def _data(self) -> StoredStateData: ... # noqa, type: ignore | |||
There was a problem hiding this comment.
This, and the next change, are drive-bys. I weirdly get ruff complaining about these but only some of the time that it's run (I haven't dug into why that is). They do not seem to be necessary, so simplest to just remove.
tonyandrewmeyer
commented
Feb 7, 2024
benhoyt
reviewed
Feb 8, 2024
benhoyt
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
JUJU_ACTION_UUIDenvironment variable's value asActionEvent.id.Fixes #1121