feat: support change-update notice and pebble-change-updated event #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
commented
Apr 4, 2024
tonyandrewmeyer
approved these changes
Apr 9, 2024
wallyworld
approved these changes
Apr 9, 2024
| CUSTOM = 'custom' | ||
| """A custom notice reported via the Pebble client API or ``pebble notify``. | ||
| The key and data fields are provided by the user. The key must be in | ||
| the format ``example.com/path`` to ensure well-namespaced notice keys. |
There was a problem hiding this comment.
Yeah, we validate it (in the Pebble server), so the workload will get an error if it tries to add a custom notice (pebble notify) with an invalid key. The API does "reasonable effort" validation with a regex.
IronCore864
approved these changes
Apr 9, 2024
benhoyt
added a commit
to benhoyt/operator
that referenced
this pull request
Apr 12, 2024
…event (canonical#1170)" This reverts commit b7e5ba3.
benhoyt
added a commit
that referenced
this pull request
Apr 12, 2024
) This reverts #1170 (commit b7e5ba3) as this feature has been reverted in Juju on the 3.5 branch, due to the issues described at this PR: juju/juju#17191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
pebble-change-updatedevent (Juju PR juju/juju#17118), adding a newPebbleChangeUpdatedEventtype and{container_name}_pebble_change_updatedevent you can observe.The event has a
get_change()method to easily fetch the associatedpebble.Changeobject.It also adds
Harness.pebble_notifysupport for thepebble.NoticeType.CHANGE_UPDATEnotice type. To use that, you say: