New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up logging output #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
Although possibly out of scope, the Operator Framework 1.5.0 up and running.
logs have limited use/interest for the user. Would we ever expect this not to be the case? If it wasn't, would a user be able be reasonably expected to do anything about it?
That said, Penny's comment on them makes sense, might we change the output to something richer? I don't have strong opinions on this though.
Inspiration
<CHARM_NAME> run started with <X> <Y> <Z> env vars
- X Y Z being interesting ones.------------- <UNIT NAME> started -------------
- Just for demarcation of runs when usingjuju debug-log --include-module unit.<app>/N
or something. Kinda ugly though.
I wouldn't mind at all having a broader 'welcome' log on start/install, or anyway when the OF fires up for the first time. We could specialize log output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(A richer log message on start also makes sense, though possibly part of a separate PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small recommendation.
…nto logging-cleanup
Fixes #796
Got rid of a few 'unhelpful' debug logger calls.
Checklist
QA steps
Changelog