Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RHEL family OS custom image kickstart blscfg sed statement #218

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

qcu266
Copy link
Contributor

@qcu266 qcu266 commented Mar 11, 2024

to fix: #217

relates to: #191

Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the quotes looks alright, I'm wondering if the other sed commands could do with similar changes

@qcu266
Copy link
Contributor Author

qcu266 commented Mar 11, 2024

I found a previous PR that was the same as this one, but he only fixed rhel and centos at the time, #169.

I used grep to filter the code, and only the following six places have this problem

image

@qcu266 qcu266 changed the title fix: RHEL family OS custom image kickstart blgcfg sed statement fix: RHEL family OS custom image kickstart blscfg sed statement Mar 12, 2024
Copy link
Contributor

@alexsander-souza alexsander-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alexsander-souza alexsander-souza merged commit d5a87f5 into canonical:main Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom image could not boot.
3 participants