Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RemovePath and pebble rm command #146

Merged
merged 5 commits into from Dec 13, 2022
Merged

Implement RemovePath and pebble rm command #146

merged 5 commits into from Dec 13, 2022

Conversation

anpep
Copy link
Collaborator

@anpep anpep commented Aug 30, 2022

No description provided.

benhoyt
benhoyt reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure whether this was ready for review yet, but I did a quick pass. I'll review more thoroughly later -- just let me know.

client/files.go Outdated Show resolved Hide resolved
client/files.go Outdated Show resolved Hide resolved
client/files.go Outdated Show resolved Hide resolved
client/files.go Outdated Show resolved Hide resolved
cmd/pebble/cmd_rm.go Outdated Show resolved Hide resolved
cmd/pebble/cmd_rm.go Outdated Show resolved Hide resolved
@anpep anpep marked this pull request as ready for review September 1, 2022 14:34
@anpep anpep requested a review from flotter September 1, 2022 14:34
benhoyt
benhoyt reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We skimmed through this with Gustavo during our London mini-sprint, and it looks good. He's going to take one more pass before we merge.

client/files.go Outdated Show resolved Hide resolved
cmd/pebble/cmd_rm.go Outdated Show resolved Hide resolved
@anpep
Remove duplicated client.Error and --recursive
1e13683
@anpep
Minor fixes
11078b9 
 * Reviewed error messages.
 * Reviewed JSON style.
@benhoyt benhoyt mentioned this pull request Oct 25, 2022
Closed
5 tasks
niemeyer
niemeyer approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks Angel. Looks ready for merging, just pending conflict resolution with the prior list files PR.

@benhoyt benhoyt merged commit 32a4bd4 into canonical:master Dec 13, 2022
thp-canonical added a commit to thp-canonical/pebble that referenced this pull request Nov 20, 2023
@thp-canonical
docs(README.md): rm, push and pull are now implemented
96d5107 
These features have been implemented now:

* rm (canonical#146)
* push (canonical#147)
* pull (canonical#148)
@thp-canonical thp-canonical mentioned this pull request Nov 20, 2023
Merged
benhoyt pushed a commit that referenced this pull request Nov 20, 2023
@thp-canonical
docs(README.md): rm, push and pull are now implemented (#332)
4c0d0c4 
These features have been implemented now. Update README.md to say so:

* rm (#146)
* push (#147)
* pull (#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt left review comments

@niemeyer niemeyer niemeyer approved these changes

@flotter flotter Awaiting requested review from flotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anpep @niemeyer @benhoyt