ci(snap): cope with concurrent builds #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the Pebble release process involves a series of 3 commits under a very short amount of time. GitHub's concurrency flag is being used to cope with this, but it is unable to wait for pending workflow runs, which raises the risk of a Release workflow cancelling the previous commit workflow, where the snap is being built, if the run is pending, waiting for a GH runner. This commit forces the snap build to happen on releases also.
cjdcordeiro
force-pushed
the
always-build-snap
branch
from
3fc889e
to
a9e7622
Compare
jnsgruk
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the Pebble release process involves a series of 3 commits in a very short amount of time. GitHub's concurrency flag is being used to cope with this, but it is unable to wait for pending workflow runs (see the bug), which raises the risk of a Release workflow cancelling the previous commit workflow, where the snap is being built, if the run is pending, waiting for a GH runner.
This commit forces the snap build to happen on releases also.
This change has been tested in https://github.com/cjdcordeiro/pebble/actions/runs/7221185730 (for regular pushes to
master) and https://github.com/cjdcordeiro/pebble/actions/runs/7220657549 (for releases)