[DPE-1782] Configuration support #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloneppel
changed the title
delgod
requested changes
Oct 19, 2023
config.yaml
Outdated
| type: boolean | ||
| logging_log_min_duration_statement: | ||
| description: | | ||
| Sets the minimum running time above which statements will be logged |
There was a problem hiding this comment.
we need units for all relevant options.
or maybe even link to https://postgresqlco.nf/doc/en/param/log_min_duration_statement/14/ if Alex approve
Suggested change
| Sets the minimum running time above which statements will be logged | |
| Sets the minimum running time above which statements will be logged (ms) |
There was a problem hiding this comment.
Added defaults, allowed values and unit on fac0b95.
There was a problem hiding this comment.
Discussed with Marcelo, I would avoid references to the external resources we are not controlling.
Otherwise it will be hard to build consistent UX.
dragomirp
reviewed
Oct 19, 2023
dragomirp
reviewed
Oct 19, 2023
dragomirp
reviewed
Oct 19, 2023
…buffers upper limit
…onnection_ssl config option
This was referenced Oct 19, 2023
marceloneppel
added a commit
to canonical/postgresql-operator
that referenced
this pull request
Oct 19, 2023
delgod
approved these changes
Oct 20, 2023
dragomirp
approved these changes
Oct 20, 2023
marceloneppel
added a commit
to canonical/postgresql-operator
that referenced
this pull request
Oct 24, 2023
* Add missing parameters and add configuration support * Use fixed snap * Fix parameters validation * Add validations * Update library * Revert changes on charm.py * Add configuration logic and tests * PR feedback (including the feedback from canonical/postgresql-k8s-operator#281) * Fix TLS tests * Increase timeout
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Add missing parameters and add configuration support * Use fixed snap * Fix parameters validation * Add validations * Update library * Revert changes on charm.py * Add configuration logic and tests * PR feedback (including the feedback from canonical/postgresql-k8s-operator#281) * Fix TLS tests * Increase timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is no way to provide custom configurations to the workload (PostgreSQL database).
Solution
Add to
patroni.yamlthe requested configurations with their default values.Expose the allowed configurations through charm config options (and add validators based on the allowed values).
max_connectionsandmax_prepared_transactionscan be changed only through the Patroni API, so they are changed in the charm code differently from the other configurations.Also, added a call to
time.sleep(10)to give some time to Patroni to reload the configurations before it's possible to know which ones need a database restart. Previously, sometimes a change inshared_bufferswouldn't trigger a restart.