[DPE-3594] Fix shared buffers validation #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…e cache size value Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
approved these changes
Feb 16, 2024
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
approved these changes
Feb 16, 2024
taurus-forever
approved these changes
Feb 16, 2024
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Fix shared buffers validation Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Consider shared buffers config option value when calculating effective cache size value Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix PostgreSQL restart not being called Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add and update unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The validation for the
shared_buffersparameter was not correct. The calculus of the maximum allowed shared buffers value was not correctly converting the available memory for that to the same unit as theshared_buffersparameter that the user informs.Also, the
effective_cache_sizeparameter did not consider the user-providedshared_buffersvalue.One last issue: sometimes, the restart of the PostgreSQL database was not triggered because Patroni hadn't finished reloading the configuration (even after 10 seconds).
Solution
Fix the calculus of the maximum allowed shared buffers value to be in the same unit as the user-provided value.
Considered the user-provided shared buffers value for the effective cache size parameter calculus.
An improved retry mechanism was added to check whether a restart is needed after a configuration change.