Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Switch to ruff formatter #424

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[MISC] Switch to ruff formatter #424

merged 2 commits into from
Mar 18, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Mar 18, 2024

Switch to ruff formatter

Comment on lines -93 to -98
@pytest.mark.group(1)
async def test_none() -> None:
"""Empty test so that the suite will not fail if all tests are skippedi."""
pass


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other tests are skipped so we no longer need this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black linting would fail on the lib. It should be fine, since it's internal for PG and PGB charms.

@dragomirp dragomirp marked this pull request as ready for review March 18, 2024 13:41
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx!

@dragomirp dragomirp merged commit 1668283 into main Mar 18, 2024
44 checks passed
@dragomirp dragomirp deleted the ruff-formater branch March 18, 2024 18:04
BON4 pushed a commit to BON4/postgresql-k8s-operator that referenced this pull request May 20, 2024
* Switch to ruff formatter

* Remove none test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants