Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2671] Rerender and reenable pgbackrest config and service #461

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[DPE-2671] Rerender and reenable pgbackrest config and service #461

merged 1 commit into from
Apr 30, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Apr 29, 2024 •
edited

Issue

Pgbackrest service and configuration are not enabled if a pod is recreated

Solution

Render and start pgbackrest ssl service on pebble ready

@dragomirp dragomirp marked this pull request as ready for review April 30, 2024 00:20
marceloneppel
marceloneppel approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Is it possible to add an integration test deleting the pod and ensuring the file is recreated?

taurus-forever
taurus-forever approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 for here or followup PR for the test here.

@dragomirp dragomirp merged commit 2d103c0 into main Apr 30, 2024
46 checks passed
@dragomirp dragomirp deleted the dpe-2671-rerender-pgbackrestconf branch April 30, 2024 16:07
@dragomirp dragomirp mentioned this pull request May 1, 2024
Merged
BON4 pushed a commit to BON4/postgresql-k8s-operator that referenced this pull request May 20, 2024
@dragomirp
Rerender and reenable pgbackrest config and service (canonical#461)
80e9ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taurus-forever taurus-forever taurus-forever approved these changes

@marceloneppel marceloneppel marceloneppel approved these changes

@lucasgameiroborges lucasgameiroborges Awaiting requested review from lucasgameiroborges

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dragomirp @taurus-forever @marceloneppel