Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3202] Architecture specific snap revision #345

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Feb 5, 2024

Adds CPU architecture specific snap revisions. We will need this to keep on holding snap revisions on multiple architectures.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cf04016) 79.94% compared to head (a79ff63) 80.00%.

Files Patch % Lines
src/charm.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   79.94%   80.00%   +0.06%     
==========================================
  Files          10       10              
  Lines        2169     2176       +7     
  Branches      344      344              
==========================================
+ Hits         1734     1741       +7     
  Misses        368      368              
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as discussed, please use 14/latest snap track.

@dragomirp
Copy link
Contributor Author

LGTM, but as discussed, please use 14/latest snap track.

14/latest or 14/stable? Currently it's set to 14/stable.

src/charm.py Outdated Show resolved Hide resolved
@dragomirp dragomirp marked this pull request as ready for review February 6, 2024 02:17
@taurus-forever
Copy link
Contributor

LGTM, but as discussed, please use 14/latest snap track.

14/latest or 14/stable? Currently it's set to 14/stable.

Midnight comment. sure 14/stable. :-D

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx!

Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/charm.py Outdated Show resolved Hide resolved
@dragomirp dragomirp merged commit acc0d26 into main Feb 6, 2024
44 checks passed
@dragomirp dragomirp deleted the dpe-3202-arm branch February 6, 2024 22:21
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Arm tweaks

* Bump snap revision

* Snap version bump

* Tweak plugins test

* Architecture based snap revision

* Try to set channel

* Revert conftest

* Remove string revision check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants