[DPE-3257] Fix network cut tests #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 80.00% 79.99% -0.02%
==========================================
Files 10 10
Lines 2176 2179 +3
Branches 344 345 +1
==========================================
+ Hits 1741 1743 +2
- Misses 368 369 +1
Partials 67 67 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
changed the title
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…cut-test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
taurus-forever
approved these changes
Feb 8, 2024
| @@ -1633,7 +1633,6 @@ files = [ | |||
| {file = "PyYAML-6.0.1-cp311-cp311-win_amd64.whl", hash = "sha256:bf07ee2fef7014951eeb99f56f39c9bb4af143d8aa3c21b1677805985307da34"}, | |||
| {file = "PyYAML-6.0.1-cp312-cp312-macosx_10_9_x86_64.whl", hash = "sha256:855fb52b0dc35af121542a76b9a84f8d1cd886ea97c84703eaa6d88e37a2ad28"}, | |||
| {file = "PyYAML-6.0.1-cp312-cp312-macosx_11_0_arm64.whl", hash = "sha256:40df9b996c2b73138957fe23a16a4f0ba614f4c0efce1e9406a184b6d07fa3a9"}, | |||
| {file = "PyYAML-6.0.1-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl", hash = "sha256:a08c6f0fe150303c1c6b71ebcd7213c2858041a7e01975da3a99aed1e7a378ef"}, | |||
There was a problem hiding this comment.
Why is it constantly flicking? CC: @carlcsaposs-canonical
Each PR removes and re-adds this dependency here.
P.S. ARM.
There was a problem hiding this comment.
maybe different versions of poetry on different developer's machines?
There was a problem hiding this comment.
I will also do some tests using the Multipass Ubuntu VM here to understand it.
dragomirp
approved these changes
Feb 9, 2024
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Fix network cut test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix network cut test without IP change Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update unit test Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix retrieval of units IPs Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Improve checks for readiness Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix IP retrieval Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix IP retrieval Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Fix IP retrieval Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The two network cut tests are being skipped from CI due to instabilities on them.
Solution
Enable the tests again on CI.
Fix the causes of the issues in the tests:
juju execbecause the IP reported byjuju statusmight be outdated sometimes.