[DPE-3559] Stabilise restore cluster test #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 80.03% 81.33% +1.29%
==========================================
Files 10 10
Lines 2209 2207 -2
Branches 355 353 -2
==========================================
+ Hits 1768 1795 +27
+ Misses 372 343 -29
Partials 69 69 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
approved these changes
Feb 14, 2024
taurus-forever
approved these changes
Feb 15, 2024
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Improve unit status about no connection to primary Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Update other users passwords in the second cluster Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> * Add unit tests Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com> --------- Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The restore cluster test was failing a lot of times due to the
replicationuser password not being updated, which led to follower units not being able to connect to the primary to get the data.Solution
Update all users' passwords in the test.
Also, use this opportunity to change the blocked status with the message
no primary in the clusterto a waiting status because it's resolved after some time (no need for user action).