Updated test_landscape_scalable_bundle_db test
#378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 81.33% 80.83% -0.50%
==========================================
Files 10 10
Lines 2207 2244 +37
Branches 353 362 +9
==========================================
+ Hits 1795 1814 +19
- Misses 343 356 +13
- Partials 69 74 +5 ☔ View full report in Codecov by Sentry. |
dragomirp
reviewed
Mar 5, 2024
tests/integration/test_db_admin.py
Outdated
| # (by checking that the connection string doesn't work anymore). | ||
| async with ops_test.fast_forward(): | ||
| await ops_test.model.applications[DATABASE_APP_NAME].remove_relation( | ||
| f"{DATABASE_APP_NAME}:{RELATION_NAME}", f"{LANDSCAPE_APP_NAME}:{RELATION_NAME}" |
There was a problem hiding this comment.
Suggested change
| f"{DATABASE_APP_NAME}:{RELATION_NAME}", f"{LANDSCAPE_APP_NAME}:{RELATION_NAME}" | |
| f"{DATABASE_APP_NAME}:{RELATION_NAME}", f"{LANDSCAPE_APP_NAME}:db" |
The interface on Landscape's side is called db.
There was a problem hiding this comment.
Relation name is db-admin but the interface on Landscape side is called db
There was a problem hiding this comment.
Vote back. Linter is not happy: https://github.com/canonical/postgresql-operator/actions/runs/8159411639/job/22388324477
marceloneppel
approved these changes
Mar 12, 2024
dragomirp
approved these changes
Mar 14, 2024
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* test_landscape_scalable_bundle_db | add logic for checking users deletion after relation broken * Updated `test_landscape_scalable_bundle_db` test * updated Co-authored-by: Dragomir Penev <6687393+dragomirp@users.noreply.github.com> * fix lint test * updated * updated * updated * updated * updated * updated * updated * updated --------- Co-authored-by: Dragomir Penev <6687393+dragomirp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
User should be created on a relation-joined event, and the user should be dropped on a relation-departed event
Solution
Added missed logic for
db_admintest where checking that user dropped after relation removed