Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3644] Test for Ubuntu Advantage subordinate #397

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Mar 13, 2024

Subordinate test deploys ubuntu-advantage charm as well.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (1bc4f24) to head (1f4d256).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #397   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          10       10           
  Lines        2244     2244           
  Branches      362      362           
=======================================
  Hits         1814     1814           
  Misses        356      356           
  Partials       74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp marked this pull request as ready for review March 13, 2024 13:40
@dragomirp dragomirp changed the title [DPE-3644] Test fro Ubuntu Pro subordinate [DPE-3644] Test for Ubuntu Advantage subordinate Mar 13, 2024
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tnx!

@dragomirp dragomirp merged commit 5abb33f into main Mar 14, 2024
49 checks passed
@dragomirp dragomirp deleted the dpe-3644-ubuntupro branch March 14, 2024 11:53
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Test fro Ubuntu Pro subordinate

* Switch to ubuntu advantage charm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants