Metrics path per unit #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
requested review from
Abuelodelanada,
rbarry82,
dstathis and
simskij
as code owners
simskij
approved these changes
Sep 29, 2022
sed-i
force-pushed
the
feature/metrics_path_per_unit
branch
from
19ccc81
to
ac11304
Compare
Abuelodelanada
approved these changes
Sep 29, 2022
rbarry82
approved these changes
Sep 29, 2022
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
With #370 implemented, now wildcard targets are expanded to individual jobs.
However, the provider's constructor currently takes a hostname rather than a url, and (ingress) path cannot be inferred.
Solution
Change the provider constructor to take a url. This is a non-breaking change because prometheus_scrape wasn't published since the
external_hostnamearg was introduced.Context
Depends on #370.
Testing Instructions
Afaict, existing utests and itest provide sufficient coverage.
Release Notes
Add support for a custom metrics path per unit.