validate incoming scrape jobs #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstathis
requested review from
sed-i,
Abuelodelanada,
rbarry82,
lucabello,
PietroPasotti and
simskij
as code owners
Abuelodelanada
approved these changes
Jan 27, 2023
sed-i
reviewed
Jan 27, 2023
PietroPasotti
approved these changes
Feb 8, 2023
sed-i
reviewed
Feb 11, 2023
dstathis
force-pushed
the
validate_scrape_jobs
branch
from
e2ca58a
to
a8577c1
Compare
dstathis
force-pushed
the
validate_scrape_jobs
branch
2 times, most recently
from
d2f9a0b
to
87615e1
Compare
dstathis
force-pushed
the
validate_scrape_jobs
branch
from
87615e1
to
44fb4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #314
Solution
Create a minimal Prometheus config and check it with cos-tool.
Testing Instructions
Provide an invalid scrape config and check that it does not get written to disk.
Release Notes
Prometheus-k8s now validates incoming scrape jobs