Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scheme to alertmanagers config section #495

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Add scheme to alertmanagers config section #495

merged 8 commits into from
Jul 14, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jul 7, 2023 •
edited

Issue

The alertmanagers section in prometheus's config is rendered without a scheme and without tls_config, and prometheus uses http by default.

Solution

  • Add scheme to alertmanager config.
  • Figure out how to populate the tls_config section with a ca_file that matches alertmanager.

This PR goes in tandem with canonical/alertmanager-k8s-operator#171.

Reference: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#tls_config

Context

canonical/cos-lite-bundle#75

Testing Instructions

  • Pack alertmanager and prom from the two PRs
  • Deploy and relate prom to alertmanager, and alertmanager to self-signed-certificates
  • Confirm alerts are firing on prom's /api/v1/alerts and that the same alerts show in alertmanagers /api/v2/alerts.

Release Notes

Add scheme to alertmanagers config section.

@sed-i sed-i mentioned this pull request Jul 7, 2023
Merged
3 tasks
@sed-i sed-i marked this pull request as ready for review July 14, 2023 03:32
@lucabello lucabello mentioned this pull request Jul 14, 2023
Open
@sed-i
Copy link
Contributor Author

sed-i commented Jul 14, 2023

Itests passed but not reflected on the PR page here. Merging.

@sed-i sed-i merged commit 91c9df7 into main Jul 14, 2023
12 checks passed
@sed-i sed-i deleted the feature/alertmanager_tls branch July 14, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@lucabello lucabello Awaiting requested review from lucabello lucabello is a code owner

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sed-i @Abuelodelanada