Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI to actually test against various Python versions #586

Closed
simondeziel opened this issue Jun 12, 2024 · 0 comments · Fixed by #592
Closed

Fix CI to actually test against various Python versions #586

simondeziel opened this issue Jun 12, 2024 · 0 comments · Fixed by #592
Assignees
@simondeziel @hamistao

Comments

@simondeziel
Copy link
Member

The integration tests use the apt-get installed Python version rather than the one set by the setup-python action.
simondeziel added a commit to simondeziel/pylxd that referenced this issue Jul 4, 2024
@simondeziel
github: replace python versions by OS versions
6aff890 
Due to canonical#586, we cannot test with anything by the OS provided python version. As
such, let's test with multiple OS versions and against the respective LXD
version for that OS.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel mentioned this issue Jul 4, 2024
Closed
@hamistao hamistao self-assigned this Jul 4, 2024
simondeziel added a commit to simondeziel/pylxd that referenced this issue Jul 4, 2024
@simondeziel
github: use canonical/setup-lxd action to setup LXD
f06fe89 
Fixes canonical#586, probably due to `sudo -g lxd` not preserving the `$PATH` in which
the actions/setup-python had put the python executable.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel self-assigned this Jul 4, 2024
@simondeziel simondeziel mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simondeziel simondeziel

@hamistao hamistao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

github: use canonical/setup-lxd action to setup LXD simondeziel/pylxd
2 participants
@simondeziel @hamistao