Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin urllib3 to 1.x #539

Merged
merged 1 commit into from May 5, 2023
Merged

Pin urllib3 to 1.x #539

merged 1 commit into from May 5, 2023

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented May 5, 2023

Otherwise with urllib3 2.0.2:

>>> import pylxd
>>> c = pylxd.Client()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/pylxd/client.py", line 413, in __init__
    response = self.api.get()
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/pylxd/client.py", line 209, in get
    response = self.session.get(self._api_endpoint, *args, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 600, in get
    return self.request("GET", url, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/urllib3/connectionpool.py", line 790, in urlopen
    response = self._make_request(
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
TypeError: HTTPConnection.request() got an unexpected keyword argument 'chunked'

Otherwise with `urllib3` `2.0.2`:

>>> import pylxd
>>> c = pylxd.Client()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/pylxd/client.py", line 413, in __init__
    response = self.api.get()
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/pylxd/client.py", line 209, in get
    response = self.session.get(self._api_endpoint, *args, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 600, in get
    return self.request("GET", url, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 587, in request
    resp = self.send(prep, **send_kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/sessions.py", line 701, in send
    r = adapter.send(request, **kwargs)
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/urllib3/connectionpool.py", line 790, in urlopen
    response = self._make_request(
  File "/var/lib/juju/agents/unit-lxd-6/charm/venv/urllib3/connectionpool.py", line 496, in _make_request
    conn.request(
TypeError: HTTPConnection.request() got an unexpected keyword argument 'chunked'

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review May 5, 2023 08:47
@stgraber stgraber merged commit 0102dba into canonical:master May 5, 2023
7 checks passed
@simondeziel simondeziel deleted the old-urllib3 branch May 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants