Introduce storage volume snapshots #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
reviewed
Jun 7, 2024
|
@simondeziel For now I ask to focus the comments on the functions' behaviors. I still have some work to do on comments, docstrings and user messages. |
hamistao
changed the title
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
8 times, most recently
from
02b1177
to
d6feb45
Compare
simondeziel
reviewed
Jun 13, 2024
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
2 times, most recently
from
82cb2df
to
d8cf378
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 97.81% 96.51% -1.31%
==========================================
Files 32 32
Lines 3073 3153 +80
==========================================
+ Hits 3006 3043 +37
- Misses 67 110 +43 ☔ View full report in Codecov by Sentry. |
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
14 times, most recently
from
316e94d
to
f23163a
Compare
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
from
4f1b06c
to
7786743
Compare
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
3 times, most recently
from
f60412f
to
d5b7f52
Compare
|
@simondeziel @markylaing This is ready for review again. |
simondeziel
requested changes
Jul 2, 2024
There was a problem hiding this comment.
"integration/test_storage: Remove unused imports" should be folded with integration: Move storage helper functions to testing
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
from
d5b7f52
to
444abde
Compare
simondeziel
approved these changes
Jul 2, 2024
simondeziel
requested changes
Jul 2, 2024
integration/test_storage.py
Outdated
| new_description = "first snapshot" | ||
| first_snapshot.description = new_description | ||
| first_snapshot.save(wait=True) | ||
| self.assertEquals(volume.snapshots.get("first").description, new_description) |
There was a problem hiding this comment.
Suggested change
| self.assertEquals(volume.snapshots.get("first").description, new_description) | |
| self.assertEqual(volume.snapshots.get("first").description, new_description) |
This should address the following warning:
integration/test_storage.py::TestStorageVolumeSnapshot::test_create_get_restore_delete_volume_snapshot
/home/runner/work/pylxd/pylxd/integration/test_storage.py:207: DeprecationWarning: Please use assertEqual instead.
self.assertEquals(volume.snapshots.get("first").description, new_description)
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
…ume` Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
This class adds support for creating snapshots, restoring a volume from a snapshot, retrieving snapshot information and deleting a snapshot. Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
This method returns True when two models are of the same class and have the same attributes with the same values. This is needed for the StorageVolumeSnapshot tests. Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
storage_volume_snapshot_basic_usage
branch
from
444abde
to
f9da9c1
Compare
simondeziel
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a few features related to custom storage volumes snapshots to pyLXD:
The unit tests will be added in a later PR if necessary.
Scheduling was already supported since it is done through config key settings on the StorageVolume object.
This also does some refactoring on previously existing code and some other changes made necessary by the new features and tests.