This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
uv: Set start_index correctly when no closed segments present #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue came up while running the jepsen tests, steps are roughly: - Node receives snapshot install and deletes all closed segments preceding the snapshot. - After installing the snapshot, the node receives AppendEntries and adds the entries to an open segment. - Node gets killed. - Node boots and UvLoad closes the open segment using start_index 1, ignoring the index of the snapshot that is present in the data dir. - Node fails to start because the newly closed segment and the snapshot are inconsistent with a message `raft_start(): io: last entry on disk has index 383, which is behind last snapshot's index 3072"` Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue came up while running the jepsen tests, steps are roughly:
preceding the snapshot.
adds the entries to an open segment.
ignoring the index of the snapshot that is present in the data dir.
inconsistent with a message
raft_start(): io: last entry on disk has index 383, which is behind last snapshot's index 3072"Signed-off-by: Mathieu Borderé mathieu.bordere@canonical.com