This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Remove blocking barrier #445

Closed

MathieuBordere wants to merge 3 commits into canonical:master from MathieuBordere:remove-blocking

Contributor

MathieuBordere commented Jun 27, 2023 •

edited

Loading

This is a draft PR that implements the approach to remove the (non)blocking barrier distinction discussed in #444

I believe @cole-miller is not a huge fan of the approach. Alternatives would be:

new segment format that encodes the index explicitly (more risky, think about downgrading raft versions, also need to be able to still handle old format segments)
run a barrier on the first snapshot only, this carries a performance penalty as new writes will be blocked during the snapshot.
...

Mathieu Borderé added 3 commits

June 27, 2023 13:43


          uv barrier: remove blocking / non-blocking distinction.

c554d3c


          uv: Segment open-0 indicates start index 1.

23b2a0a

Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>


          uv segment: Can't assume counter > 0 anymore.

Contributor Author

MathieuBordere commented Jun 27, 2023

Let me first fix the tests ... :-)

MathieuBordere closed this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.