Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: add clean command #93

Merged
merged 2 commits into from
Sep 27, 2022
Merged

commands: add clean command #93

merged 2 commits into from
Sep 27, 2022

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 27, 2022

  • Have you signed the CLA?

Overview

Add command rockcraft clean with stubbed out TODOs. This lays down groundwork needed to refactor clean_project_environments().

There are 3 ways the clean command is used:

1. rockcraft clean <part>

  • cleans a specific part
  • added as a TODO to be implemented later

2. rockcraft clean --destructive-mode

  • cleans the local build environment
  • added as a TODO, but users shouldn't encouter this, since destructive mode is also unsupported and labeled with a TODO

3. rockcraft clean

  • cleans a provider environment
  • added as a TODO, but will be supported in my next PR

(CRAFT-1394)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankss

@tigarmo tigarmo enabled auto-merge (squash) September 27, 2022 20:14
@tigarmo tigarmo merged commit c4502a7 into canonical:main Sep 27, 2022
@mr-cal mr-cal deleted the clean-command branch September 27, 2022 20:29
@cjdcordeiro
Copy link
Collaborator

thanks for the PR.

could you please create the docs for it? and for future PRs, it is easier to stay on track if we don't merge without the corresponding docs (otherwise some poor soul will have to, later on, spend hours on digging and writing existing features :p )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants