New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Implementation of the TLS interface #10

Merged

gruyaume merged 20 commits into main from dev-tls

Jun 27, 2023

Collaborator

gruyaume commented Jun 21, 2023 •

edited

Loading

Description

Implementation of the TLS interface.

Note:

I would have hoped to validate the certificate expiring behavior but I couldn't find a way with scenario to trigger custom events. Here I don't want to test the TLS lib, I just want to test the charm code. Following a conversation with Pietro on this subject, he opened an issue for this: [4.0] support for custom events ops-scenario#41

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that validate the behaviour of the software
I validated that new and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have bumped the version of the library

gruyaume requested a review from a team as a code owner

June 21, 2023 19:39

github-advanced-security bot found potential problems

View reviewed changes

lib/charms/tls_certificates_interface/v2/tls_certificates.py Fixed Show fixed Hide fixed

ghislainbourgeois requested changes

View reviewed changes

tests/unit/test_charm.py Outdated Show resolved Hide resolved

gruyaume requested a review from ghislainbourgeois

June 22, 2023 12:04

saltiyazan reviewed

View reviewed changes

src/charm.py Show resolved Hide resolved

gruyaume requested a review from saltiyazan

June 22, 2023 12:37

saltiyazan reviewed

View reviewed changes

src/charm.py Show resolved Hide resolved

saltiyazan reviewed

View reviewed changes

src/charm.py Show resolved Hide resolved

saltiyazan reviewed

View reviewed changes

src/charm.py Show resolved Hide resolved

saltiyazan reviewed

View reviewed changes

src/charm.py Show resolved Hide resolved

gruyaume requested a review from saltiyazan

June 22, 2023 13:11

gruyaume and others added 6 commits

June 22, 2023 12:15


          [Feat] Implementation of the TLS interface

067348b


          Replaces patches for push/pull with file manipulation

36ee001


          Update src/charm.py

cbeabd6

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

7b19f3e

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

b3349d6

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

890f637

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>

saltiyazan reviewed

View reviewed changes

README.md Show resolved Hide resolved

saltiyazan reviewed

View reviewed changes

src/charm.py Outdated Show resolved Hide resolved

saltiyazan approved these changes

View reviewed changes

Contributor

saltiyazan left a comment

Other than the 2 minor comments, it looks good :)

gruyaume and others added 10 commits

June 23, 2023 06:40


          [Feat] Implementation of the TLS interface

6ecbab2


          Replaces patches for push/pull with file manipulation

c2c3781


          Update src/charm.py

09cf397

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

f3a1385

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

a1483dd

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Update src/charm.py

5c8d99c

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          Fixes cert directory

7092e9b


          Bumps lib version

99ee1a0


          Update README.md

0a4f689

Co-authored-by: saltiyazan <yazan.salti.19@gmail.com>


          [Feat] Implementation of the TLS interface

02682ab

gruyaume force-pushed the dev-tls branch from 8275aec to 02682ab Compare

June 23, 2023 10:41

gruyaume added 4 commits

June 23, 2023 06:44


          Fixes cert directory in tests

bf51df0


          Fixes startup command

b3007bb


          Fixes unit test

2dc4c3a


          Uses container filesystems instead of patching pushes and pulls

01d7554

ghislainbourgeois approved these changes

View reviewed changes

gruyaume merged commit 1a3d701 into main

7 checks passed

gruyaume deleted the dev-tls branch

June 27, 2023 19:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment