Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LoadBalancer Service #36

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Conversation

DanielArndt
Copy link
Member

@DanielArndt DanielArndt commented Sep 7, 2023

Description

Exposes an external LoadBalancer service for the UPF, similar to canonical/sdcore-amf-k8s-operator#24 for the AMF

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@DanielArndt DanielArndt requested a review from a team as a code owner September 7, 2023 19:56
@gatici

This comment was marked as outdated.

src/charm.py Show resolved Hide resolved
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two general comments:

  1. I think we could mention in the README that it is possible to expose UPF, but LB is required for that. We could also have an integration test validating the exposure. WDYT?
  2. Please add docstrings :)

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@DanielArndt
Copy link
Member Author

Two general comments:

  1. I think we could mention in the README that it is possible to expose UPF, but LB is required for that. We could also have an integration test validating the exposure. WDYT?

Sure, I can add that to the README.

I'd be happy to give integration tests a shot, but at this point I'm not quite sure what that would look like. I'll have to tackle those when I get back on Wednesday.

  1. Please add docstrings :)

Happy to add docstrings where you think they would be useful. I'm not a fan of docstrings on internal functions where the docstring just reiterates the function name. i.e.

def _create_external_upf_service(self) -> None:
    """Creates the external UPF service."""

The above seems like a waste, but maybe there is something you'd like me to be more explicit about?

src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@gatici

This comment was marked as outdated.

Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased before merging. LGTM.

@DanielArndt DanielArndt merged commit cb37885 into main Sep 15, 2023
10 checks passed
@DanielArndt DanielArndt deleted the telco-656-use-loadbalancer-service branch September 15, 2023 13:13
@DanielArndt DanielArndt mentioned this pull request Sep 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants